Re: Problems with update to b266
Posted by Wade Walker on Jan 27, 2011; 3:58pm
URL: https://forum.jogamp.org/Problems-with-update-to-b266-tp2280749p2363048.html
Hey, that looks pretty good
For TextRenderer.java, perhaps you checked in a version with the wrong line endings? That's the most common cause of every line being different. Once the checkin is correct, the line diffs should show only the few lines you changed.
The only other thing I'd suggest would be to add class comments to your three new classes to say briefly why they were created and what they do. The purpose seems obvious to you now, but it will help later developers
And I guess the copyright dates on the JogAmp community headers should now be 2011.
URL: https://forum.jogamp.org/Problems-with-update-to-b266-tp2280749p2363048.html
Hey, that looks pretty good
For TextRenderer.java, perhaps you checked in a version with the wrong line endings? That's the most common cause of every line being different. Once the checkin is correct, the line diffs should show only the few lines you changed.
The only other thing I'd suggest would be to add class comments to your three new classes to say briefly why they were created and what they do. The purpose seems obvious to you now, but it will help later developers
And I guess the copyright dates on the JogAmp community headers should now be 2011.
| Free forum by Nabble | Edit this page |