Re: typo in CLCommandQueue.putCopyImageToBuffer
Posted by
Michael Bien on
Sep 28, 2011; 1:43am
URL: https://forum.jogamp.org/typo-in-CLCommandQueue-putCopyImageToBuffer-tp3374149p3374653.html
thank you very much.
those copy and paste bugs are a bit embarrassing :/
both methods have currently no unit test. I will fix that tomorrow.
btw since you helped me spotting bugs already a few times, would you be
interested in doing some api review of more experimental areas?
thanks,
michael
On 09/28/2011 12:20 AM, notzed [via jogamp] wrote:
>
> Hi again Michael,
>
> Spotted another typo, didn't seem worth a real bug report:
>
> int ret = cl.clEnqueueCopyImageToBuffer(ID, dstBuffer.ID, srcImage.ID,
> ibA, ibB, dstOffset,
> conditions, conditionIDs,
> events==null ? null : events.IDs);
>
> dstBuffer.ID and srcImage.ID should be swapped.
>
> On nvidia/gpu I don't know what it did (didn't copy anything i presume), but
> on amd/cpu it spat with an invalid object error.
>
> FWIW github's source code browser now runs like a pig and makes my laptop
> hot ...
>
> Cheers,
> Michael