Re: joal extension support
Posted by Sven Gothel on Feb 08, 2012; 11:55am
URL: https://forum.jogamp.org/joal-extension-support-tp3721871p3725642.html
On 02/07/2012 09:26 AM, notzed [via jogamp] wrote:
>
>
> Morning,
>
> I'm looking at adding some extension support for joal, specifically for the
> still unfinished openal-soft loopback device.
>
> Apart from not believing anyone can put up with ant, I think I have the
> basic stuff going. I have successfully captured the mixer output into a raw
> audio dump with a bit of code using the experimental loopback stuff.Great stuff - thank you for your work!
>
> I wasn't sure where to put things or how to structure the gluegen code: i
> just copied the ALC stuff.
>
> Also, I just want o make sure i'm using the right fork from the cms, i
> presume it's Sven's? https://github.com/sgothel
Sure, or use jogamp's repo (same state).
>
> I've attached the work-in-progress diff , but it's still got a bit of cruft
> left in it.
Can't you 'just' fork JOAL from the repository (my gluegen/joal or jogamp's
gluegen/joal), make a 'wip' branch (work in progress) we can review ?
>
> I added a bunch of stuff from the current head of openal-soft to alext.h,
yes, and duplicate type defines, which would require manual type validation.
Could you drop the common types in a common file, or just include al.h
in alext.h, while dropping it's generation for those types and functions ?
> and the loopback device stuff, which also meant copying all the AL* and ALC*
> types, and renaming some of the function pointers so gluegen can find the
> right prototypes. Messy, but seemed the easiest solution for such a small
> api.
After it's cleaned up and hence no side effects occur,
I will pull from your repository - sure.
I know we don't have a lot unit tests in JOAL since it is not so well
maintained. However, since I assume you did test the new functionality
somehow, can you add a few unit tests for it ?
When I write source code, I usually don't add the 'author' tag in the
source files and may just drop our generic JogAmp copyright header.
I know .. others chose to add their 'name'. However, since we all will
edit the files at some point in time, I guess 'personalizing' the files
is a bad idea, since such statement will be always wrong in the future
when many will edit it. Hence not having 'names' in the copyright or
author section won't lead to a long list of names :)
Proper identification of authorship is done via the SCM (IMHO).
>
> Cheers,
> !Z
>
> http://forum.jogamp.org/file/n3721871/build.diff build.diff
Cheers, Sven
URL: https://forum.jogamp.org/joal-extension-support-tp3721871p3725642.html
On 02/07/2012 09:26 AM, notzed [via jogamp] wrote:
>
>
> Morning,
>
> I'm looking at adding some extension support for joal, specifically for the
> still unfinished openal-soft loopback device.
>
> Apart from not believing anyone can put up with ant, I think I have the
> basic stuff going. I have successfully captured the mixer output into a raw
> audio dump with a bit of code using the experimental loopback stuff.
>
> I wasn't sure where to put things or how to structure the gluegen code: i
> just copied the ALC stuff.
>
> Also, I just want o make sure i'm using the right fork from the cms, i
> presume it's Sven's? https://github.com/sgothel
Sure, or use jogamp's repo (same state).
>
> I've attached the work-in-progress diff , but it's still got a bit of cruft
> left in it.
Can't you 'just' fork JOAL from the repository (my gluegen/joal or jogamp's
gluegen/joal), make a 'wip' branch (work in progress) we can review ?
>
> I added a bunch of stuff from the current head of openal-soft to alext.h,
yes, and duplicate type defines, which would require manual type validation.
Could you drop the common types in a common file, or just include al.h
in alext.h, while dropping it's generation for those types and functions ?
> and the loopback device stuff, which also meant copying all the AL* and ALC*
> types, and renaming some of the function pointers so gluegen can find the
> right prototypes. Messy, but seemed the easiest solution for such a small
> api.
After it's cleaned up and hence no side effects occur,
I will pull from your repository - sure.
I know we don't have a lot unit tests in JOAL since it is not so well
maintained. However, since I assume you did test the new functionality
somehow, can you add a few unit tests for it ?
When I write source code, I usually don't add the 'author' tag in the
source files and may just drop our generic JogAmp copyright header.
I know .. others chose to add their 'name'. However, since we all will
edit the files at some point in time, I guess 'personalizing' the files
is a bad idea, since such statement will be always wrong in the future
when many will edit it. Hence not having 'names' in the copyright or
author section won't lead to a long list of names :)
Proper identification of authorship is done via the SCM (IMHO).
>
> Cheers,
> !Z
>
> http://forum.jogamp.org/file/n3721871/build.diff build.diff
Cheers, Sven
signature.asc (910 bytes) | Free forum by Nabble | Edit this page |