Login  Register

Re: joal extension support

Posted by notzed on Feb 09, 2012; 1:24pm
URL: https://forum.jogamp.org/joal-extension-support-tp3721871p3729448.html

Sven Gothel wrote
>
> I've attached the work-in-progress diff , but it's still got a bit of cruft
> left in it.

Can't you 'just' fork JOAL from the repository (my gluegen/joal or jogamp's
gluegen/joal), make a 'wip' branch (work in progress) we can review ?
No, I don't think so.  I find using git about as offensive as it's name, and you're pretty lucky I somehow managed to get a clean diff out of it.  Every time I try something more complex I end up with a broken repository and the loss of a few hours of life i'll never get back!
>
> I added a bunch of stuff from the current head of openal-soft to alext.h,
yes, and duplicate type defines, which would require manual type validation.

Could you drop the common types in a common file, or just include al.h
in alext.h, while dropping it's generation for those types and functions ?
Sure.  I don't think i can come with a neat regex for the constants though so it might have to be a common file.
> and the loopback device stuff, which also meant copying all the AL* and ALC*
> types, and renaming some of the function pointers so gluegen can find the
> right prototypes.  Messy, but seemed the easiest solution for such a small
> api.

After it's cleaned up and hence no side effects occur,
I will pull from your repository - sure.

I know we don't have a lot unit tests in JOAL since it is not so well
maintained. However, since I assume you did test the new functionality
somehow, can you add a few unit tests for it ?
I added it to a music player, but i suppose i can think something simpler up.
When I write source code, I usually don't add the 'author' tag in the
source files and may just drop our generic JogAmp copyright header.
I know .. others chose to add their 'name'. However, since we all will
edit the files at some point in time, I guess 'personalizing' the files
is a bad idea, since such statement will be always wrong in the future
when many will edit it. Hence not having 'names' in the copyright or
author section won't lead to a long list of names :)
Proper identification of authorship is done via the SCM (IMHO).
Well I just copied some existing file and didn't think it made sense to leave the other name in.  I too find the @author thing a bit pointless but when using netbeans it's too much hassle to turn it off so I ignore it like I do adverts on web pages.