Re: joal extension support
Posted by Sven Gothel on Feb 09, 2012; 5:38pm
URL: https://forum.jogamp.org/joal-extension-support-tp3721871p3730161.html
On 02/09/2012 02:24 PM, notzed [via jogamp] wrote:
>
>
>
> Sven Gothel wrote
>>
>>>
>>> I've attached the work-in-progress diff , but it's still got a bit of
>>> cruft
>>> left in it.
>>
>> Can't you 'just' fork JOAL from the repository (my gluegen/joal or
>> jogamp's
>> gluegen/joal), make a 'wip' branch (work in progress) we can review ?
>>
> No, I don't think so. I find using git about as offensive as it's name, and
> you're pretty lucky I somehow managed to get a clean diff out of it. Every
> time I try something more complex I end up with a broken repository and the
> loss of a few hours of life i'll never get back!
>Sorry to hear that you don't like it.
My move to git was because of my frustration with svn,
I really messed up with the server side repository using different
client/server svn versions. Sure, hg would have been an alternative
as well - but you have to choose at some point in time.
Well, ok .. so it is and sure I accept your choice,
even though it makes life harder for us - ie. you cannot directly maintain it.
So we continue on a patch base, I would just need the git hash for which
those patches apply to. Since JOAL is rarely updated .. I guess even that
doesn't matter :)
>
>>>
>>> I added a bunch of stuff from the current head of openal-soft to alext.h,
>> yes, and duplicate type defines, which would require manual type
>> validation.
>>
>> Could you drop the common types in a common file, or just include al.h
>> in alext.h, while dropping it's generation for those types and functions ?
>>
> Sure. I don't think i can come with a neat regex for the constants though
> so it might have to be a common file.A common header file is just fine, thank you.
>
>
>>> and the loopback device stuff, which also meant copying all the AL* and
>>> ALC*
>>> types, and renaming some of the function pointers so gluegen can find the
>>> right prototypes. Messy, but seemed the easiest solution for such a
>>> small
>>> api.
>>
>> After it's cleaned up and hence no side effects occur,
>> I will pull from your repository - sure.
>>
>> I know we don't have a lot unit tests in JOAL since it is not so well
>> maintained. However, since I assume you did test the new functionality
>> somehow, can you add a few unit tests for it ?Unit tests ?
Looking forward to merging your [cleaned up] patch manually.
~Sven
URL: https://forum.jogamp.org/joal-extension-support-tp3721871p3730161.html
On 02/09/2012 02:24 PM, notzed [via jogamp] wrote:
>
>
>
> Sven Gothel wrote
>>
>>>
>>> I've attached the work-in-progress diff , but it's still got a bit of
>>> cruft
>>> left in it.
>>
>> Can't you 'just' fork JOAL from the repository (my gluegen/joal or
>> jogamp's
>> gluegen/joal), make a 'wip' branch (work in progress) we can review ?
>>
> No, I don't think so. I find using git about as offensive as it's name, and
> you're pretty lucky I somehow managed to get a clean diff out of it. Every
> time I try something more complex I end up with a broken repository and the
> loss of a few hours of life i'll never get back!
>
My move to git was because of my frustration with svn,
I really messed up with the server side repository using different
client/server svn versions. Sure, hg would have been an alternative
as well - but you have to choose at some point in time.
Well, ok .. so it is and sure I accept your choice,
even though it makes life harder for us - ie. you cannot directly maintain it.
So we continue on a patch base, I would just need the git hash for which
those patches apply to. Since JOAL is rarely updated .. I guess even that
doesn't matter :)
>
>>>
>>> I added a bunch of stuff from the current head of openal-soft to alext.h,
>> yes, and duplicate type defines, which would require manual type
>> validation.
>>
>> Could you drop the common types in a common file, or just include al.h
>> in alext.h, while dropping it's generation for those types and functions ?
>>
> Sure. I don't think i can come with a neat regex for the constants though
> so it might have to be a common file.
>
>
>>> and the loopback device stuff, which also meant copying all the AL* and
>>> ALC*
>>> types, and renaming some of the function pointers so gluegen can find the
>>> right prototypes. Messy, but seemed the easiest solution for such a
>>> small
>>> api.
>>
>> After it's cleaned up and hence no side effects occur,
>> I will pull from your repository - sure.
>>
>> I know we don't have a lot unit tests in JOAL since it is not so well
>> maintained. However, since I assume you did test the new functionality
>> somehow, can you add a few unit tests for it ?
Looking forward to merging your [cleaned up] patch manually.
~Sven
signature.asc (910 bytes) | Free forum by Nabble | Edit this page |