Re: Building git master on OS X 10.8

Posted by jrh on
URL: https://forum.jogamp.org/Building-git-master-on-OS-X-10-8-tp4025646p4026243.html

Sven Gothel wrote
On 09/22/2012 07:50 PM, jrh [via jogamp] wrote:
>     Sven Gothel wrote
>     Thank you. Maybe you can add your findings to bugzilla, so they don't get
>     lost ?
>
> Is there an existing bug that I should add it to, or should I create a new one?
A new one pls.
OK, will do. Just received the confirmation email so I can create a bugzilla account.

Sven Gothel wrote
>
>     Sven Gothel wrote
>     Then .. we would need to put all this permanent w/o hurting other OSX
>     versions, then it would be ready for a git pull.
>
> The source file #include changes I made should be usable as-is, i.e.

Are they working on _all_ platforms (i.e. also compile on OSX 10.7.* w/ Java6, and
all other supported platforms ?
The latter is the difficulty .. and for sure a bit annoying part.
Yes. For the one file I put the change inside of an #ifdef __APPLE__, and the other is only compiled on Mac OS X anyway. The path <JavaVM/jawt_md.h> should be fine on OS X for all previous versions of Java, as far as I know. That's what I've always used in the past, anyway. The compiler already knows how to interpret <Framework/header.h> to find the file at Framework.framework/Headers/header.h without requiring any -I flags; may as well take advantage of that.

Similarly, you guys are using
#import <JavaNativeFoundation.h>
 and then passing
<compilerarg value="-I${java.osx.frameworks.dir}/JavaNativeFoundation.framework/Headers" />
when you could do the slightly shorter
#import <JavaNativeFoundation/JavaNativeFoundation.h>
 and
<compilerarg value="-F${java.osx.frameworks.dir}" />

Of course really, the jawt_md.h inside of Oracle's JDK *should* work. I think it's a bug that they appear to be shipping a stock Unix (Solaris?) jawt_md.h instead of adopting Apple's. If that gets fixed, then this #include change could get reverted.