Posted by
Sven Gothel on
Nov 15, 2012; 4:18pm
URL: https://forum.jogamp.org/JOGL-and-gl-glTexSubImage2D-performance-issue-on-Linux-tp4026810p4026968.html
On 11/15/2012 04:58 PM, Umka [via jogamp] wrote:
> Guys,
>
> I'm sorry I don't have time for doing things totally right with that gluegen
> patch landing/inspecting, etc. What if I send it (not really production ready
> but works for me) and you just get idea of the fix and some of you produce a
> better fix?
>
"Guy", I am the maintainer of GlueGen and I cannot accept such a fly-bye diff
without reasoning or explanation.
Rule-1 (especially for new sources of human input):
- Don't mix your semantic patch w/ whitespace changes
- I need an explanation
- I probably need a unit test
- I need a full name of a real person incl. valid email address,
best as a git formatted email patch (if not a pull request)
This is very important especially for GlueGen, since it's failure
means failure of all JogAmp modules.
And 'no time' is no excuse to not serve the bare minimum (a
discussion/explanation).
So either you are capable of delivering a proper patch with comments
and explanations w/o whitespaces, or it's 'gone w/ the guys'.
Sorry for being harsh - but we need to keep our QA standards.
And .. guess what ? Our time is limited as well :)
~Sven