Login  Register

Re: PNG interlace

Posted by Sven Gothel on Dec 19, 2012; 8:57pm
URL: https://forum.jogamp.org/PNG-interlace-tp4027479p4027576.html

On 12/19/2012 08:23 PM, Hernan [via jogamp] wrote:

> Hi, I'm the PNGJ developer. I'm glad that other people (apart from me) are
> using the library. I see that you have copied the source code, changing the
> package names. I'm not sure that's a good idea (both copying the source code
> instead of just referencing the pngj.jar, and also changing the package
> names). Unless  you had to make modifications of my code, just referencing the
> jar would seem  more clean and neat to me, and make updates much simpler.
>  Anyway, it's you decision.  Suggestions about the library and issues reports
> are welcomed.
> Regarding interlaced PNG, they are supported now (for reading), though less
> tested - and much less efficient if you are reading line by line.
>
Hi Hernan, great that you are here.

Here is the git commit incl. the motivation for
moving it in our namespace (collision, footprint):

+++

commit 40830196070013432bc5f453eb31cfe4c64e0510
Author: Sven Gothel <[hidden email]>
Date:   Sat Apr 7 15:28:37 2012 +0200

    Merge PNGJ 0.85 into namespace

    PNGJ Version 0.85  (1 April 2012)

    Apache 2.0 License

    http://code.google.com/p/pngj/

    Merged code:
      - Changed namespace ar.com.hjg.pngj -> jogamp.opengl.util.pngj
        to avoid collision when using a different version of PNGJ.

      - Removed test and lossy packages and helper classes
        to reduce footprint.

    License information is added in main LICENSE.txt file.

+++

If the package name collision is of no concern for JOGL users,
we can keep it in it's original place ofc.
I just wanted it to be 'anonymous' somehow, since JOGL users may
like to use an updated version of PNGJ, or use the lossy stuff,
which would not be possible in this case.

Updating PNGJ is on the list .. yup, definitely.

As mentioned earlier - thank you for your awesome efficient implementation,
very much appreciated.

~Sven

> Hernan


signature.asc (909 bytes) Download Attachment