Posted by Sven Gothel on Mar 14, 2013; 12:32am
URL: https://forum.jogamp.org/Indexed-PNG-tp4028430p4028627.html

On 03/13/2013 09:58 PM, gouessej [via jogamp] wrote:
> I have just modified your patch a little bit:
> https://github.com/gouessej/jogl/commit/9fb623ef3c3feb30200c512e09b3507cccb76602

Thank you - it has no white space changes, hence enhance to read the diff.

So I assume CT's change is almost the same here - since I cannot diff
w/o having to do lots of work (pull merge and diff w/o white space change).

Looks good, similar to Hernan's code
  https://code.google.com/p/pngj/source/browse/pnjg/src/ar/com/hjg/pngj/test/SampleConvPalToTrueColor.java

Do we have a unit test ?

Could you extend 'TestPNGTextureFromFileNEWT', which currently tests:

  normal           test-ntscN01-160x90.png
  interlaced       test-ntscI01-160x90.png
  interlaced-gamma test-ntscIG01-160x90.png

and add for indexed:
  palette RGB      test-ntscP301-160x90.png
  palette RGBA     test-ntscP401-160x90.png

maybe we could also need (while we are at):

  normal RGBA       test-ntscN401-160x90.png
  interlaced RGBA   test-ntscI401-160x90.png

Please tell me if you like to do so, otherwise I will add the above
after the merge and test.

~Sven