Login  Register

Re: I made a few fixes to JOCL - how do I contribute them back?

Posted by Xerxes Rånby on Sep 04, 2013; 9:03am
URL: https://forum.jogamp.org/I-made-a-few-fixes-to-JOCL-how-do-I-contribute-them-back-tp4029976p4029979.html

2013-09-03 21:52, lixoman100 [via jogamp] skrev:
Hello,

I was using JOCL for a project that is already running on JOGL and ran into a few issues. After much investigation, I found that a few of those issues were caused by bugs in the JOCL library.

These are simple bugs - 3 cases of arguments passed in the wrong order and 1 case of an unsupported define necessary for GL context sharing in Mac OS X. In the case of the missing int define, I just passed a hard-coded integer, since I don't know if I can put it in the CL.java file (as it appears to be generated during the build process).

My fixes are simple and crude, but I need them for my project to work correctly (and to work on Mac). Since more people might have been affected by these bugs, I assume that contributing these fixes back could help others. Is that the case? If so, how should I proceed?


If you reply to this email, your message will be added to the discussion below:
http://forum.jogamp.org/I-made-a-few-fixes-to-JOCL-how-do-I-contribute-them-back-tp4029976.html
To start a new topic under jocl, email [hidden email]
To unsubscribe from jogamp, click here.
NAML

You may start with sending a patch of each file you changed to this list. This allows us to understand the problem better.

You may also open a bugreport for each issue you observe using JOCL.
This is the best way to report issues and make sure we fix them in futher releases.
https://jogamp.org/bugzilla/

If you have a github account clone the JogAmp/jocl git https://github.com/JogAmp/jocl and send a pull request with your changes.

Cheers
Xerxes