Login  Register

Re: java11 + release progress thread (also: review)

Posted by gouessej on Aug 19, 2019; 10:42am
URL: https://forum.jogamp.org/java11-release-progress-thread-also-review-tp4039948p4039958.html

The deallocator implements Runnable:
http://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template#l70

The cleaner calls this runnable:
http://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/jdk/internal/ref/Cleaner.java#l143

CleanerImpl implements Runnable:
http://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java#l43

The source code changed in the meantime :( Cleaner implemented Runnable:
http://hg.openjdk.java.net/jdk/jdk11/file/da165fd9c886/jdk/src/java.base/share/classes/jdk/internal/ref/Cleaner.java#l61

This change is really annoying:
http://hg.openjdk.java.net/jdk/jdk11/diff/6059f74bacdf/jdk/src/java.base/share/classes/jdk/internal/ref/Cleaner.java
http://hg.openjdk.java.net/jdk/jdk11/rev/6059f74bacdf

You're right, your solution is better.
Julien Gouesse | Personal blog | Website