I hope you find it useful.
It works with my fork of sweethome3d (https://github.com/bigianb/refactoredHome3D) but I've not tested it any further as getting the 3D window of sh3d to work on my laptop was the sole motivator of this.
Thank you very much for your contribution. Please can you make a clean pull request without import changes into the repository used for Java3D 1.7.0? Phil would be very happy to review and accept your change :)
I cleaned up the PR on the 1.6 repo. I'm not sure how to raise a PR against Phil's repo though.
Why? well github does not let me fork Phil's 1.7 repo because I already have a Java3D fork (the 1.6 hharrison one).
I guess I could make a 1.7 branch in my repo ... pull Phil's master into there, make the changes and set a PR from that branch. I won't have time to try that for a while though. Given that the change is only 4 lines of code, maybe you can just cherry pick that change over?
Thanks for this change it looks really clean and simple.
As Julien states is preferred if your contribution come from you. But if it's complicated to coordinate 2 forks of an upstream repo and you are ok with it'll I'll just cherry pick the changes into the 1.7 repo.
As Julien says 1.7.0 is the best branch to pull as it has the most fixes and improvements in it.
Java3D 1.7 running on jogl 2.3.2 works with Jre 1.8 and java 10 for all the examples, though java 10 outputs a warning message about reflection.
Currently my installed version of java 9 does not work, but that may be because I used a pre-release, so I'll need to look into that.
I think I’ve got it figured out - I’ve added your repo as an extra remote to mine and fetched your dev1.7.0 branch. I built your dev branch yesterday and have changed the paths in my SweetHome3D fork to build against it.
Now I just need to apply the changes to java3d core, test it and raise a PR.
Hopefully I’ll find some time this evening to do that.